Skip to content

Conversation

@valkirilov
Copy link
Member

@valkirilov valkirilov commented Nov 28, 2025

What

Fix the alignment of the Copilot and Insights icons in the navigation when on the Databases tab.

Note: Also, remove the deprecated SASS, transform it to "styled components" and update AI rules.

Testing

  1. Open Redis Insight and go to the Databases tab

Observe the placement of the icon in the top right corner.

Before

Screenshot 2025-11-28 at 15 27 29

After

Screenshot 2025-11-28 at 15 26 59

Note

Aligns Copilot/Insights/profile actions in the Home page header and replaces SCSS with styled-components using layout components, theme spacing, and semantic colors; updates frontend rules accordingly.

  • UI (HomePageTemplate)
    • Replace styles.module.scss with HomePageTemplate.styles.ts using styled-components and layout components (Row, FlexGroup).
    • Apply theme spacing (space800, space200) and semantic colors for header background/border; remove magic numbers and CSS vars.
    • Adjust header structure to use PageDefaultHeader with align="center", justify="between", gap="l"; wrap content with PageWrapper and ExplorePanelWrapper.
    • Align header actions (CopilotTrigger, InsightsTrigger, OAuthUserProfile) using layout props.
  • Docs/Rules
    • Add guidelines to: use gap prop, theme spacing, semantic colors, and layout components instead of div.

Written by Cursor Bugbot for commit 4324d77. This will update automatically on new commits. Configure here.

Fixed misalignment of Coplit and Insights icons on the Databases page by:

- Adding align and justify props for proper alignment

- Matching the layout pattern used in InstanceHeader

References: #RI-7774
Added new sections documenting best practices learned from migration:
- Use gap prop instead of custom margins
- Use theme spacing instead of magic numbers
- Use semantic colors from theme instead of CSS variables
- Use layout components (Row/Col/FlexGroup) instead of div

References: #RI-7774
@valkirilov valkirilov self-assigned this Nov 28, 2025
@valkirilov valkirilov marked this pull request as ready for review November 28, 2025 13:30
<PageWrapper>
<ExplorePanelWrapper>
<ExplorePanelTemplate>{children}</ExplorePanelTemplate>
</ExplorePanelWrapper>
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: Side panel padding applied to wrong element

The panelClassName prop that previously passed padding-bottom: 16px styling to ExplorePanelTemplate (and through it to SidePanelsStyledSidePanel) has been removed. Instead, ExplorePanelWrapper now applies padding-bottom to a wrapper around the entire template. This changes where the padding is applied - from the side panel component itself to an outer container, which has different visual behavior. The SidePanels component uses panelClassName to style the StyledSidePanel element directly, so the side panels will no longer receive the intended padding-bottom styling.

Additional Locations (1)

Fix in Cursor Fix in Web

@github-actions
Copy link
Contributor

Code Coverage - Frontend unit tests

St.
Category Percentage Covered / Total
🟢 Statements 82.9% 20976/25303
🟡 Branches 68.16% 8858/12996
🟡 Functions 77.95% 5733/7355
🟢 Lines 83.31% 20541/24657

Test suite run success

5446 tests passing in 703 suites.

Report generated by 🧪jest coverage report action from 4324d77

@valkirilov valkirilov merged commit 58dd250 into main Nov 28, 2025
28 checks passed
@valkirilov valkirilov deleted the fe/bugfix/RI-7774/fix-icon-alignment-databases-page branch November 28, 2025 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants