fix: remove deprecated empty-session-on-missing behavior from GET working-memory

[bsbodden]

Summary

• Removes the deprecated backward-compatibility path where GET /v1/working-memory/{session_id} returned an empty WorkingMemory with unsaved=True for missing sessions (old clients without X-Client-Version header or version < 0.12.0)
• All clients now consistently receive 404 for missing sessions, preventing bugs from mismatched PUT/GET parameters
• Removes parse_client_version(), is_old_client(), the X-Client-Version header parameter, and the new_session/unsaved fields from WorkingMemoryResponse
• Updates docs/api.md to remove the deprecated fields from the schema table

Test plan

• uv run ruff check && uv run ruff format — passes
• uv run pytest tests/test_api.py -v — all tests pass
• uv run pytest — full suite passes (704 passed, 102 skipped)
• Verify client library still works — integration test confirms server omits new_session/unsaved and client model (fields default to None) parses the response without errors

Closes #136

---

Note

Medium Risk
Behavior change in GET /v1/working-memory/{session_id} (and its response schema) can break older clients that relied on implicit empty sessions or on new_session/unsaved fields; otherwise the change is localized to a single endpoint and its model/docs/tests.

Overview
GET /v1/working-memory/{session_id} now always returns 404 when a session is missing, removing the deprecated compatibility path that returned an empty, non-persisted session for older clients.

The API drops the X-Client-Version handling and removes deprecated WorkingMemoryResponse fields (new_session, unsaved); docs and tests are updated accordingly, including a test ensuring the client model still deserializes responses when those fields are absent.

^{Written by Cursor Bugbot for commit 7ee093d. This will update automatically on new commits. Configure here.}

[jit-ci]

🛡️ Jit Security Scan Results

✅ No security findings were detected in this PR

---

^{Security scan by Jit}

[Copilot]

Pull request overview

This PR removes deprecated backward-compatibility behavior from the GET /v1/working-memory/{session_id} endpoint that previously returned an empty session with unsaved=True for missing sessions to support old clients. After this change, all clients consistently receive a 404 error for missing sessions, which aligns with proper REST semantics and prevents bugs caused by parameter mismatches between PUT and GET operations.

Changes:

• Removed version-checking functions (parse_client_version(), is_old_client()) and the X-Client-Version header parameter from the GET endpoint
• Updated get_working_memory() to always return 404 for missing sessions instead of conditionally creating empty unsaved sessions
• Removed deprecated new_session and unsaved fields from WorkingMemoryResponse model
• Updated tests to expect 404 responses and removed old client version test case
• Applied code formatting improvements to assert statements following Black/Ruff conventions

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File	Description
agent_memory_server/api.py	Removed version checking functions, X-Client-Version header parameter, and deprecated empty-session-on-missing behavior; simplified get_working_memory to always return 404 for missing sessions
agent_memory_server/models.py	Removed deprecated new_session and unsaved fields from WorkingMemoryResponse
tests/test_api.py	Updated test expectations to check for 404 on missing sessions, removed old client version test, and applied Black/Ruff formatting to assert statements

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[github-actions]

The code changes correctly remove the deprecated backward-compatibility behavior. However, there's a documentation inconsistency that should be addressed.

Documentation Issue:
The file docs/api.md still documents the new_session and unsaved fields in the WorkingMemoryResponse model (lines 533-534), but these fields have been removed from the server implementation. This documentation should be updated to reflect the current API schema.

Client Library Consideration:
The client libraries (Python, JavaScript, and Java) still have the new_session and unsaved fields in their WorkingMemoryResponse models. While this won't cause immediate breakage (clients will receive null values), consider documenting the plan for deprecating these fields in the client libraries in a future release.

---

🤖 Automated review complete. Please react with 👍 or 👎 on the individual review comments to provide feedback on their usefulness.

[bsbodden]

Addressed both points from the automated review:

1. docs/api.md — Removed new_session and unsaved from the WorkingMemoryResponse schema table (7ee093d).

2. Client library fields — The client models (new_session, unsaved) default to None so they won't break. Added an integration test (test_response_omits_deprecated_fields_and_client_model_still_parses) that verifies the server no longer emits these fields and the client model still parses correctly (cb26c99). Removing the fields from the client libraries is a separate concern for a future client release.

[cursor]

Cursor Bugbot has reviewed your changes and found 1 potential issue.

^{Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.}

[cursor]

Stale comment references removed new_session field

Low Severity

The comment on this line still references new_session ("no new_session for PUT") even though this PR removes the new_session field entirely from WorkingMemoryResponse. The parenthetical is now meaningless and could confuse future readers into thinking new_session is still a concept in the codebase.

 

[vishal-bala]

LGTM 👍