chore: align CI and dev setup through makefile#256
Merged
tylerhutcherson merged 1 commit intomainfrom Mar 27, 2026
Merged
Conversation
🛡️ Jit Security Scan Results✅ No security findings were detected in this PR
Security scan by Jit
|
Contributor
There was a problem hiding this comment.
Pull request overview
This PR standardizes the repository’s “full verification” workflow by making Make targets the shared entrypoints for both local development and CI, reducing drift between environments and aligning Ruff/pre-commit versions.
Changes:
- Introduces
make verifyas the canonical full-check flow and expands Make targets for common test slices. - Updates GitHub Actions workflows and developer docs to invoke the shared Make targets instead of duplicating
uvcommands. - Aligns
ruff-pre-commithook revision with the Ruff version in the lockfile; applies resulting formatting updates across tests/docs/notebook examples.
Reviewed changes
Copilot reviewed 22 out of 22 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
Makefile |
Adds verify and additional sync/test targets; documents CI-aligned semantics in target descriptions. |
.github/workflows/python-tests.yml |
Switches lint/tests/service-tests jobs to call make sync(-dev), make pre-commit, make test, make test-api. |
.github/workflows/test-fork-pr.yml |
Uses make sync and make test-api for fork PR service testing. |
.pre-commit-config.yaml |
Pins ruff-pre-commit revision to match the Ruff version used by the project lockfile. |
docs/development.md |
Updates developer workflow to use make setup/test/test-api/pre-commit/verify. |
README.md |
Updates the development quickstart to the Make-based workflow and notes OPENAI_API_KEY requirement for make verify. |
AGENTS.md |
Refreshes contributor/agent workflow commands to the Make-based entrypoints. |
examples/agent_memory_server_interactive_guide.ipynb |
Formatting/consistency tweaks to match updated tooling behavior. |
tests/test_api.py |
Assertion formatting changes consistent with updated lint/format tooling. |
tests/test_working_memory.py |
Assertion formatting changes consistent with updated lint/format tooling. |
tests/test_tool_contextual_grounding.py |
Assertion formatting changes consistent with updated lint/format tooling. |
tests/test_thread_aware_grounding.py |
Assertion formatting changes consistent with updated lint/format tooling. |
tests/test_mcp.py |
Assertion formatting changes consistent with updated lint/format tooling. |
tests/test_long_term_memory.py |
Assertion formatting changes consistent with updated lint/format tooling. |
tests/test_issue_235.py |
Assertion formatting changes consistent with updated lint/format tooling. |
tests/test_full_integration.py |
Assertion formatting changes consistent with updated lint/format tooling. |
tests/test_contextual_grounding_integration.py |
Assertion formatting changes consistent with updated lint/format tooling. |
tests/test_context_percentage_calculation.py |
Assertion formatting changes consistent with updated lint/format tooling. |
tests/test_client_tool_calls.py |
Assertion formatting changes consistent with updated lint/format tooling. |
tests/integration/test_task_error_message_clearable.py |
Assertion formatting changes consistent with updated lint/format tooling. |
tests/integration/test_deduplication_e2e.py |
Assertion formatting changes consistent with updated lint/format tooling. |
agent-memory-client/tests/test_tool_schemas.py |
Assertion formatting changes consistent with updated lint/format tooling. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #255
This PR aligns local development and CI around a single verification workflow.
It adds
make verifyas the canonical full-check entrypoint, keeps the existing lower-level maketargets for individual steps, updates CI to call those shared Make targets instead of duplicating
raw
uvcommands, and refreshesREADME/docs/AGENTSguidance to point developers at the sameworkflow.
It also aligns the pinned ruff-pre-commit version with the Ruff version installed in the
project so formatting behavior is consistent between local runs and CI.
Note
Medium Risk
Moderate risk because CI behavior and dependency syncing now depend on new/changed
Makefiletargets and an updatedruff-pre-commitrevision, which could change lint outcomes or break workflows if targets drift.Overview
CI workflows now run linting and tests via shared
Makefiletargets (make sync(-dev),make pre-commit,make test,make test-api) instead of inlininguvcommands, and addmake verifyas the canonical local/CI-equivalent verification entrypoint.Developer docs (
README.md,docs/development.md,AGENTS.md) are updated to point to the new make-based workflow, and.pre-commit-config.yamlbumpsruff-pre-committov0.14.8for consistent formatting behavior. The remaining diffs are largely formatting-only changes in tests/notebooks (assert wrapping/line breaks) to satisfy updated lint/format rules.Written by Cursor Bugbot for commit 05f41f1. This will update automatically on new commits. Configure here.