Skip to content

chore: align CI and dev setup through makefile#256

Merged
tylerhutcherson merged 1 commit intomainfrom
chore/align-local-ci-verify
Mar 27, 2026
Merged

chore: align CI and dev setup through makefile#256
tylerhutcherson merged 1 commit intomainfrom
chore/align-local-ci-verify

Conversation

@tylerhutcherson
Copy link
Copy Markdown
Contributor

@tylerhutcherson tylerhutcherson commented Mar 27, 2026

Fixes #255

This PR aligns local development and CI around a single verification workflow.

It adds make verify as the canonical full-check entrypoint, keeps the existing lower-level make
targets for individual steps, updates CI to call those shared Make targets instead of duplicating
raw uv commands, and refreshes README/docs/AGENTS guidance to point developers at the same
workflow.

It also aligns the pinned ruff-pre-commit version with the Ruff version installed in the
project so formatting behavior is consistent between local runs and CI.


Note

Medium Risk
Moderate risk because CI behavior and dependency syncing now depend on new/changed Makefile targets and an updated ruff-pre-commit revision, which could change lint outcomes or break workflows if targets drift.

Overview
CI workflows now run linting and tests via shared Makefile targets (make sync(-dev), make pre-commit, make test, make test-api) instead of inlining uv commands, and add make verify as the canonical local/CI-equivalent verification entrypoint.

Developer docs (README.md, docs/development.md, AGENTS.md) are updated to point to the new make-based workflow, and .pre-commit-config.yaml bumps ruff-pre-commit to v0.14.8 for consistent formatting behavior. The remaining diffs are largely formatting-only changes in tests/notebooks (assert wrapping/line breaks) to satisfy updated lint/format rules.

Written by Cursor Bugbot for commit 05f41f1. This will update automatically on new commits. Configure here.

@tylerhutcherson tylerhutcherson self-assigned this Mar 27, 2026
Copilot AI review requested due to automatic review settings March 27, 2026 15:44
@tylerhutcherson tylerhutcherson added the documentation Improvements or additions to documentation label Mar 27, 2026
@tylerhutcherson tylerhutcherson removed their assignment Mar 27, 2026
Copy link
Copy Markdown

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review completed. The PR successfully aligns local development and CI workflows through standardized Makefile targets. The changes are well-structured and maintain consistency across documentation. No suggestions at this time.

@jit-ci
Copy link
Copy Markdown

jit-ci bot commented Mar 27, 2026

🛡️ Jit Security Scan Results

CRITICAL HIGH MEDIUM

✅ No security findings were detected in this PR


Security scan by Jit

@tylerhutcherson tylerhutcherson changed the title Align CI and dev setup through makefile chore: align CI and dev setup through makefile Mar 27, 2026
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR standardizes the repository’s “full verification” workflow by making Make targets the shared entrypoints for both local development and CI, reducing drift between environments and aligning Ruff/pre-commit versions.

Changes:

  • Introduces make verify as the canonical full-check flow and expands Make targets for common test slices.
  • Updates GitHub Actions workflows and developer docs to invoke the shared Make targets instead of duplicating uv commands.
  • Aligns ruff-pre-commit hook revision with the Ruff version in the lockfile; applies resulting formatting updates across tests/docs/notebook examples.

Reviewed changes

Copilot reviewed 22 out of 22 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
Makefile Adds verify and additional sync/test targets; documents CI-aligned semantics in target descriptions.
.github/workflows/python-tests.yml Switches lint/tests/service-tests jobs to call make sync(-dev), make pre-commit, make test, make test-api.
.github/workflows/test-fork-pr.yml Uses make sync and make test-api for fork PR service testing.
.pre-commit-config.yaml Pins ruff-pre-commit revision to match the Ruff version used by the project lockfile.
docs/development.md Updates developer workflow to use make setup/test/test-api/pre-commit/verify.
README.md Updates the development quickstart to the Make-based workflow and notes OPENAI_API_KEY requirement for make verify.
AGENTS.md Refreshes contributor/agent workflow commands to the Make-based entrypoints.
examples/agent_memory_server_interactive_guide.ipynb Formatting/consistency tweaks to match updated tooling behavior.
tests/test_api.py Assertion formatting changes consistent with updated lint/format tooling.
tests/test_working_memory.py Assertion formatting changes consistent with updated lint/format tooling.
tests/test_tool_contextual_grounding.py Assertion formatting changes consistent with updated lint/format tooling.
tests/test_thread_aware_grounding.py Assertion formatting changes consistent with updated lint/format tooling.
tests/test_mcp.py Assertion formatting changes consistent with updated lint/format tooling.
tests/test_long_term_memory.py Assertion formatting changes consistent with updated lint/format tooling.
tests/test_issue_235.py Assertion formatting changes consistent with updated lint/format tooling.
tests/test_full_integration.py Assertion formatting changes consistent with updated lint/format tooling.
tests/test_contextual_grounding_integration.py Assertion formatting changes consistent with updated lint/format tooling.
tests/test_context_percentage_calculation.py Assertion formatting changes consistent with updated lint/format tooling.
tests/test_client_tool_calls.py Assertion formatting changes consistent with updated lint/format tooling.
tests/integration/test_task_error_message_clearable.py Assertion formatting changes consistent with updated lint/format tooling.
tests/integration/test_deduplication_e2e.py Assertion formatting changes consistent with updated lint/format tooling.
agent-memory-client/tests/test_tool_schemas.py Assertion formatting changes consistent with updated lint/format tooling.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copy link
Copy Markdown
Contributor

@vishal-bala vishal-bala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@tylerhutcherson tylerhutcherson merged commit 85d2a83 into main Mar 27, 2026
35 of 47 checks passed
@tylerhutcherson tylerhutcherson deleted the chore/align-local-ci-verify branch March 27, 2026 18:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Align local verification and CI on canonical Make targets

3 participants