Fix MCP search_long_term_memory missing background_tasks parameter #99
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The MCP server's search_long_term_memory tool was failing with: 'search_long_term_memory() missing 1 required positional argument: background_tasks' The core API function requires a HybridBackgroundTasks parameter, but the MCP function was not passing it. This fix creates a HybridBackgroundTasks instance and passes it to the core function, following the same pattern used by other MCP functions like memory_prompt. Also adds a regression test to ensure background_tasks is always passed. Fixes #85
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes a bug in the MCP server's search_long_term_memory tool where it was missing the required background_tasks parameter when calling the core API function core_search_long_term_memory. This was causing runtime failures with a "missing 1 required positional argument: 'background_tasks'" error. The fix properly creates a HybridBackgroundTasks instance and passes it to the core function, following the established pattern used by other MCP tools like memory_prompt.
Key Changes
- Added
HybridBackgroundTasksinstantiation in the MCPsearch_long_term_memorytool and passed it to the core API function - Updated existing test mock signature to include the
background_tasksparameter - Added comprehensive regression test to ensure
background_tasksis always passed correctly
Reviewed changes
Copilot reviewed 10 out of 10 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| agent_memory_server/mcp.py | Fixed search_long_term_memory by creating and passing HybridBackgroundTasks instance to core function (lines 524-529) |
| tests/test_mcp.py | Updated mock signature in test_default_namespace_injection to include background_tasks parameter (line 183), and added new regression test test_search_long_term_memory_passes_background_tasks (lines 594-628) |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
added 2 commits
December 10, 2025 09:52
The parse_datetime function was failing when receiving Unix timestamps as strings (e.g., '1765388915.12') because it tried to parse them as ISO format strings. This fix tries to parse string values as floats first before falling back to ISO format parsing.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #85
The MCP server's
search_long_term_memorytool was failing with:Root Cause
The core API function
search_long_term_memoryinapi.pyrequires aHybridBackgroundTasksparameter, but the MCP function was not passing it when callingcore_search_long_term_memory.Fix
Create a
HybridBackgroundTasksinstance and pass it to the core function, following the same pattern already used by other MCP functions likememory_promptandcreate_long_term_memory.Changes
agent_memory_server/mcp.py: AddedHybridBackgroundTasksinstance creation and pass it tocore_search_long_term_memorytests/test_mcp.py: Added regression testtest_search_long_term_memory_passes_background_tasksto ensurebackground_tasksis always passed; also updated existing test mock signatureTesting
background_tasksis passed correctly