Skip to content

Conversation

@yosifkit
Copy link
Contributor

No description provided.

@tianon
Copy link
Contributor

tianon commented Jul 10, 2014

Don't we need to also add --appendonly yes to the arguments to Redis so it actually stores the data in this volume? (http://redis.io/topics/persistence especially "Append-only file")

@yosifkit
Copy link
Contributor Author

We should add that to the documentation instead so that it stays optional to have persistent data. This PR just exposes the ability to make it persistent.

@tianon
Copy link
Contributor

tianon commented Jul 10, 2014

Ah, SGTM and LGTM.

tianon added a commit that referenced this pull request Jul 10, 2014
Update Dockerfile to have a volume for the data
@tianon tianon merged commit c350606 into redis:docker-2.8.12 Jul 10, 2014
@yuzp1996 yuzp1996 mentioned this pull request Jul 21, 2020
adamiBs pushed a commit to adamiBs/docker-library-redis that referenced this pull request Sep 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants