Add TLS support in 6.0+ and unify templates slightly more #218
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tianon
added a commit
to infosiftr/stackbrew
that referenced
this pull request
Dec 31, 2019
This only applies on 6.0+ and even then only after redis/docker-library-redis#218 merges.
tianon
added a commit
to infosiftr/stackbrew
that referenced
this pull request
Dec 31, 2019
This only applies on 6.0+ and even then only after redis/docker-library-redis#218 merges.
Contributor
Author
|
Added a test for this over in docker-library/official-images#7219. 👍 |
Contributor
Author
Contributor
Author
|
See also #219 re: |
docker-library-bot
added a commit
to docker-library-bot/official-images
that referenced
this pull request
Jan 1, 2020
Changes: - redis/docker-library-redis@0ed98d3: Merge pull request redis/docker-library-redis#218 from infosiftr/tls - redis/docker-library-redis@b6d413c: Add TLS support in 6.0+ and unify templates slightly more - redis/docker-library-redis@1e3c60f: Merge pull request redis/docker-library-redis#216 from infosiftr/templates - redis/docker-library-redis@d875ae0: Add initial templating
docker-library-bot
added a commit
to docker-library-bot/official-images
that referenced
this pull request
Jan 2, 2020
Changes: - redis/docker-library-redis@3fe75d3: Merge pull request redis/docker-library-redis#219 from infosiftr/32bit - redis/docker-library-redis@5e15797: Remove 32bit variants for 6.0+ - redis/docker-library-redis@0ed98d3: Merge pull request redis/docker-library-redis#218 from infosiftr/tls - redis/docker-library-redis@b6d413c: Add TLS support in 6.0+ and unify templates slightly more - redis/docker-library-redis@1e3c60f: Merge pull request redis/docker-library-redis#216 from infosiftr/templates - redis/docker-library-redis@d875ae0: Add initial templating
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #215
cc @J0WI -- I figured out what I was doing wrong (both
allandinstallneedBUILD_TLS=yesset, henceexport), and after doing so needed to make the "keep the deps" slightly more complicated to pick uplibsslwhich made it much easier to make 32bit more similar and thus drop a template 😄 👍I also opted to not enable this in
redis:32bitbecause to do so would require enabling adpkgforeign architecture, at which point I'm not convinced we're actually providing anything valuable over having users who need a 32bit Redis just usei386/redisdirectly (which should "just work").