DEV: local example fixes #2170
Merged
DEV: local example fixes #2170
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andy-stark-redis
approved these changes
Sep 25, 2025
There was a problem hiding this comment.
File moves are fine and the tests pass for the modified Python and JS files, so LGTM.
BTW, are you planning to add more of the generic command examples to these local files? I guess we'll need to submit them to the client repos eventually, but no need to do that just yet if you're going to make more changes.
Yes, I think so (I don't exactly remember which commands I'm doing this quarter; dotage). Thank you for the review! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No ticket.
Some refactoring of the command-related local examples: