Skip to content

DOC-5800: search: document new vector search attrib. #2209

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Oct 30, 2025
Merged

DOC-5800: search: document new vector search attrib. #2209

merged 5 commits into from
Oct 30, 2025

Conversation

@dwdougherty
Copy link
Collaborator

@dwdougherty dwdougherty commented Oct 3, 2025 •
edited
Loading

@adrianoamaral: I've posted this PR as a draft, as I think we might need to iterate on it a bit. We'll see.

@dwdougherty dwdougherty self-assigned this Oct 3, 2025
@dwdougherty dwdougherty added dev ros 8.4 Redis Open Source release 8.4 labels Oct 3, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Oct 3, 2025 •
edited by atlassian bot
Loading

DOC-5800

@dwdougherty dwdougherty marked this pull request as draft October 3, 2025 17:32
@github-actions
Copy link
Contributor

github-actions bot commented Oct 3, 2025 •
edited
Loading

Staging links:
https://redis.io/docs/staging/DOC-5800/commands/ft.search/
https://redis.io/docs/staging/DOC-5800/develop/ai/search-and-query/advanced-concepts/query_syntax/
https://redis.io/docs/staging/DOC-5800/develop/ai/search-and-query/query/vector-search/
https://redis.io/docs/staging/DOC-5800/develop/ai/search-and-query/vectors/

adrianoamaral
adrianoamaral requested changes Oct 14, 2025
View reviewed changes
Copy link
Contributor

@adrianoamaral adrianoamaral left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just few adjustments in regards Query Attributes in general.

@dwdougherty dwdougherty marked this pull request as ready for review October 14, 2025 20:56
@dwdougherty dwdougherty requested review from a team and adrianoamaral October 29, 2025 14:49
andy-stark-redis
andy-stark-redis approved these changes Oct 29, 2025
View reviewed changes
Copy link
Contributor

@andy-stark-redis andy-stark-redis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just style suggestions (except the code snippets, which are easy to fix), so basically LGTM.

@dwdougherty @andy-stark-redis
Apply suggestions from code review
55e4300 
Co-authored-by: andy-stark-redis <164213578+andy-stark-redis@users.noreply.github.com>
@dwdougherty
Copy link
Collaborator Author

dwdougherty commented Oct 29, 2025

Thank you, @andy-stark-redis!

@dwdougherty dwdougherty merged commit a67f352 into feat-ros-8.4 Oct 30, 2025
7 checks passed
@dwdougherty dwdougherty deleted the DOC-5800 branch October 30, 2025 13:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@andy-stark-redis andy-stark-redis andy-stark-redis approved these changes

@adrianoamaral adrianoamaral Awaiting requested review from adrianoamaral

Assignees

@dwdougherty dwdougherty

Labels

dev ros 8.4 Redis Open Source release 8.4

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@dwdougherty @adrianoamaral @andy-stark-redis