DOC-6100 set data type notebooks #2544
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Created config.py: Configuration and kernel spec management - Created validator.py: Input validation and language detection - Created parser.py: File parsing with marker detection - Created unwrapper.py: Code unwrapping logic - Created notebook_builder.py: Notebook creation and cell generation - Simplified jupyterize.py: Main orchestrator (696 → 142 lines) - Updated test_jupyterize.py: New module imports - Updated SPECIFICATION.md: Added implementation lessons learned Benefits: - 80% reduction in main script size - Clear separation of concerns - Each module independently testable - Easier to maintain and extend - All 25+ tests pass - Backward compatible Module sizes: - config.py: ~120 lines - validator.py: ~95 lines - parser.py: ~180 lines - unwrapper.py: ~180 lines - notebook_builder.py: ~160 lines - jupyterize.py: ~142 lines (was 696) Total: ~877 lines (vs 843 original) with much better organization
Contributor
Contributor
Contributor
Author
|
Thanks @dwdougherty ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Notebooks for the sets data type page, along with a few improvements to the notebook conversion script.