Skip to content

Conversation

@dwdougherty
Copy link
Collaborator

@dwdougherty dwdougherty commented Aug 14, 2024

This is an early draft of documentation for the Redis for VS Code extension. There's still some missing information, such as:

  • How the extension will appear in the VS Code marketplace
  • how to install it from there

These items are marked [DWD]...[DWD] in the doc. Feel free to review for general layout, etc.

I updated the PR to move the new article into the correct place, and I moved all the screenshots to /static/images.

@dwdougherty dwdougherty requested review from a team and ViktarStarastsenka and removed request for a team and ViktarStarastsenka August 14, 2024 22:29
@andy-stark-redis
Copy link
Contributor

@dwdougherty Just to check - this is in the RI section of the docs. Is this intended to be a spin-off of RI rather than a separate product?

Copy link
Contributor

@andy-stark-redis andy-stark-redis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few suggestions here and there but nothing major. Probably a bit too early to approve but this is already looking really good.


After installing the extension, your VS Code menu will look similar to the following.

<img src="../images/ri-vscode-menu.png">
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe crop this a bit and fade out towards the top? Probably just the last few buttons on the menu are enough for context.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea, but I have no idea how to do this. :(

dwdougherty and others added 2 commits August 15, 2024 06:42
Co-authored-by: andy-stark-redis <164213578+andy-stark-redis@users.noreply.github.com>
Copy link
Contributor

@andy-stark-redis andy-stark-redis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good so far :-)

Copy link
Contributor

@ViktarStarastsenka ViktarStarastsenka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dwdougherty
Copy link
Collaborator Author

Thank you, @andy-stark-redis, for merging your modified image!

@dwdougherty dwdougherty changed the title DEV: Redis in VS Code docs (preliminary) DEV: Redis in VS Code docs Aug 27, 2024
@dwdougherty dwdougherty merged commit fed144a into main Sep 9, 2024
@dwdougherty dwdougherty deleted the DOC-3505 branch September 9, 2024 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants