-
Notifications
You must be signed in to change notification settings - Fork 2.5k
feat(tracing): add trace filter for process pipeline and dial operation #3550
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Hi, I’m Jit, a friendly security platform designed to help developers build secure applications from day zero with an MVS (Minimal viable security) mindset. In case there are security findings, they will be communicated to you as a comment inside the PR. Hope you’ll enjoy using Jit. Questions? Comments? Want to learn more? Get in touch with us. |
|
Looks like the CI failed due to Docker pull issues on test images, not related to the code changes. |
|
Hello @Udhayarajan, I just reran the pipeline for you. |
|
@Udhayarajan what do you think about having the BasicCommandFilter renamed to |
that's really sounds good, I'll make the changes |
|
@ndyakov Pushed the changes, taking reference from one of the older PRs. I also saw @htemelski-redis had a different view earlier #3519 (comment) |
|
Yes, but it make sense to have it as default. Just because we had already released a version, keep the old name as well, so we don't break the contract. |
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @Udhayarajan
This PR is to address #3479.
While #3519 solves the issue partially (for Process Hook).
In this, I've added similar filters for dial hook and process pipeline hook