Skip to content

Conversation

@manisharma
Copy link
Contributor

@manisharma manisharma commented Nov 2, 2025

  • Safety harness in joinErrors function preventing panic (index out of bound)
  • Prevent unnecessary allocation in case of misconfiguration in MasterAddr function of sentinelFailover
  • Added Test & Benchmark

@jit-ci
Copy link

jit-ci bot commented Nov 2, 2025

Hi, I’m Jit, a friendly security platform designed to help developers build secure applications from day zero with an MVS (Minimal viable security) mindset.

In case there are security findings, they will be communicated to you as a comment inside the PR.

Hope you’ll enjoy using Jit.

Questions? Comments? Want to learn more? Get in touch with us.

@ndyakov
Copy link
Member

ndyakov commented Nov 3, 2025

hello @manisharma and thank you for your contribution. The build however is failing, please fix it and we can proceed with a review. If you need any assistance let me know.

@manisharma
Copy link
Contributor Author

hello @manisharma and thank you for your contribution. The build however is failing, please fix it and we can proceed with a review. If you need any assistance let me know.

@ndyakov addressed

Copy link
Member

@ndyakov ndyakov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

left a question, the check itself looks fine.

@manisharma manisharma requested a review from ndyakov November 5, 2025 03:16
Copy link
Member

@ndyakov ndyakov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@ndyakov ndyakov added the bug label Nov 5, 2025
@ndyakov ndyakov merged commit 60b748b into redis:master Nov 5, 2025
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants