fix(time): remove cached time optimization #3611
Merged
+8
−87
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ndyakov
changed the title
Member
Author
|
@ofekshenawa feel free to check the discussion in the linked issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We had a report for higher cpu usage with 9.17 that I assume is related to the constant waking up of the background goroutine to update the cached time. This PR is opened to continue the investigation of the issue and provide a potential fix. If this "optimization" of the hot path is found to be the underlying issue, it may be implemented under a configuration option that can be enabled only from people that are aware of the potential tradeoffs (higher idle cpu usage for slightly better throughput)
Potentially fixes #3608