Skip to content

Conversation

zweizeichen
Copy link
Contributor

redis[hiredis] fails to install on Python 3.14 due to missing wheels on some setups. Similar to what was done for 3.13 in #199 I:

  • Added 3.14 to the CI matrix
  • Bumped pypa/cibuildwheel to v3.2.0
  • added 3.14 to setup.py

I hope this is all that's needed for 3.14 support but I guess we won't know until CI ran.

Another suggestion a maintainer might want to look into is adding a dependabot.yaml so that you get update notifications for the pypa/cibuildwheel action. This way you would have gotten automatic 3.14 wheel builds 'for free' since July, but I guess that's a nuanced decision at what point and how to introduce testing of new Python releases to CI. Updating the action would not have added 3.14 to the test matrix.

Cheers!

Copy link

jit-ci bot commented Oct 8, 2025

Hi, I’m Jit, a friendly security platform designed to help developers build secure applications from day zero with an MVS (Minimal viable security) mindset.

In case there are security findings, they will be communicated to you as a comment inside the PR.

Hope you’ll enjoy using Jit.

Questions? Comments? Want to learn more? Get in touch with us.

@uglide uglide requested a review from Copilot October 14, 2025 10:47
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds Python 3.14 support to the project by updating CI configuration and build tools to generate wheels for the new Python version, addressing installation failures for redis[hiredis] on Python 3.14.

  • Added Python 3.14 to the CI test matrix in the integration workflow
  • Updated pypa/cibuildwheel from v2.21.3 to v3.2.0 to support Python 3.14 wheel building
  • Added Python 3.14 classifier to setup.py for proper package metadata

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File Description
setup.py Added Python 3.14 classifier to package metadata
.github/workflows/integration.yaml Added Python 3.14 to the CI test matrix
.github/workflows/REUSABLE-wheeler.yaml Updated cibuildwheel action to v3.2.0 for Python 3.14 support

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@uglide uglide changed the base branch from master to py314-support October 14, 2025 10:50
@uglide uglide merged commit 42447f2 into redis:py314-support Oct 14, 2025
35 checks passed
@uglide
Copy link
Contributor

uglide commented Oct 14, 2025

Thanks for the contribution. However, adjustments are needed for the wheel-building workflow. Let me merge it to the feature branch, and continue it from there.

uglide added a commit that referenced this pull request Oct 14, 2025
Co-authored-by: Sebastian <zweizeichen@me.com>
Co-authored-by: Sebastian Wagner <s.wagner@desy.de>
@uglide
Copy link
Contributor

uglide commented Oct 14, 2025

It turned out that cibuildwheel v3.2.0 works just fine with old settings, so I released it as v3.3.0. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants