Fix soft-links installation on non Darwin kernels #83
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
moticless
changed the title
oranagra
approved these changes
Oct 25, 2025
Contributor
|
@moticless Oops, sorry about that. I thought it was safe to require absolute paths for PREFIX. GNU Autotools imposes this limit, for example: But I guess I missed that we needed it somewhere... |
Collaborator
Author
|
@collinfunk, The Autotools may enforce absolute --prefix values, but our use of PREFIX isn’t quite equivalent. It’s often helpful to allow relative prefixes for developer builds and packaging scripts, so relaxing that restriction is the right move. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following #75 , the link commands were modified from relative to absolute for the sake of macOS.
This PR reverts the change to be relative for non Darwin kernels.