fix: handle literal string when env var is unset #66
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix: Handle literal
${REDIS_URL}string when environment variable is unsetProblem
When the
REDIS_URLenvironment variable is not set, gemini-cli passes the raw"${REDIS_URL}"string as the--urlparameter instead of omitting it or passing an empty value. This causes the Redis MCP server to attempt parsing the literal string"${REDIS_URL}"as a Redis URI, which fails with a parsing error.Root Cause
The issue occurs because:
--url ${REDIS_URL}REDIS_URLis unset, shell expansion doesn't occur, so the literal string"${REDIS_URL}"gets passedSolution
Filter out the
"${REDIS_URL}"placeholder string.This allows the server to gracefully fall back to using individual Redis connection parameters (host, port, etc.) with their default values when no valid URL is provided.
Impact