Skip to content

Add unit tests for Entra ID authentication logic #80

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 30, 2025
Merged

Add unit tests for Entra ID authentication logic #80

merged 2 commits into from
Oct 30, 2025

Conversation

@vchomakov
Copy link
Contributor

@vchomakov vchomakov commented Oct 29, 2025

This PR adds 18 comprehensive unit tests for the Entra ID authentication module (src/common/entraid_auth.py).

Tests cover:

  • Credential provider factory function
  • Token manager configuration
  • Service principal provider creation
  • Managed identity provider creation (system-assigned and user-assigned)
  • Default credential provider creation
  • Error handling and edge cases

Coverage:

  • 94% coverage for src/common/entraid_auth.py

bobymicroby
bobymicroby approved these changes Oct 30, 2025
View reviewed changes
Copy link
Member

@bobymicroby bobymicroby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vchomakov vchomakov merged commit 0a69289 into main Oct 30, 2025
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bobymicroby bobymicroby bobymicroby approved these changes

@mortensi mortensi Awaiting requested review from mortensi

@tishun tishun Awaiting requested review from tishun

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@vchomakov @bobymicroby