Missing error message on client.connect() ECONNREFUSED

[chiawendt]

Description

When attempting to connect using client.connect(), I expect the thrown error to have a meaningful message field. However, when the connection is refused, the message is an empty string.

This makes debugging difficult in environments where only err.message is logged, leading to error logs with insufficient information.

Code:

import { createClient } from "redis";

const redis = createClient({ url: "redis://localhost:12345" });

try {
  await redis.connect();
} catch (err) {
  console.log(1, err.message); // expect nonempty message, got ""
  console.log(2, err.message === ""); // got true
  console.log(3, err.name);
  console.log(4, err.code);
  console.log(5, err);
}

Stdout:

1 
2 true
3 AggregateError
4 ECONNREFUSED
5 AggregateError [ECONNREFUSED]: 
    at internalConnectMultiple (node:net:1122:18)
    at afterConnectMultiple (node:net:1689:7) {
  code: 'ECONNREFUSED',
  [errors]: [
    Error: connect ECONNREFUSED ::1:12345
        at createConnectionError (node:net:1652:14)
        at afterConnectMultiple (node:net:1682:16) {
      errno: -61,
      code: 'ECONNREFUSED',
      syscall: 'connect',
      address: '::1',
      port: 12345
    },
    Error: connect ECONNREFUSED 127.0.0.1:12345
        at createConnectionError (node:net:1652:14)
        at afterConnectMultiple (node:net:1682:16) {
      errno: -61,
      code: 'ECONNREFUSED',
      syscall: 'connect',
      address: '127.0.0.1',
      port: 12345
    }
  ]
}

Node.js Version

No response

Redis Server Version

No response

Node Redis Version

redis@5.0.0-next.6

Platform

No response

Logs

[bobymicroby]

@golopot Hi. The ECONNREFUSED error appears to be coming directly from your nodejs runtime, and it's worth noting that the message field is not actually a required field in the nodejs error specification.

Regarding your concern about debugging difficulty when only err.message is logged:

In most environments, developers have control over their logging implementation. Since you have access to the full err object, you could modify your error handling to log additional properties like err.code or the entire error object for more comprehensive debugging information.