feat(json.set): add fpha option to json.set#3235
Merged
Merged
Conversation
fpha - floating point homogenous array hint for how Redis should store arrays of fp values
bobymicroby
approved these changes
Apr 15, 2026
PavelPashov
approved these changes
Apr 15, 2026
Comment on lines
+15
to
+18
| /** | ||
| * If set, forces Redis to use the specified floating-point type for storing all FP homogeneous arrays. | ||
| */ | ||
| fpha?: 'BF16' | 'FP16' | 'FP32' | 'FP64'; |
Contributor
There was a problem hiding this comment.
Suggestion: we can add available since 8.8 in the comment
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fpha - floating point homogenous array hint for how Redis should store arrays of fp values
Note
Low Risk
Low risk: small additive change to command argument building, gated by an explicit new option and covered by unit/integration tests (including Redis 8.8+ checks).
Overview
JSON.SETnow accepts a newfphaoption that appendsFPHA <type>to the command, allowing callers to hint Redis on how to store floating-point homogeneous arrays (Redis 8.8+).Tests are expanded to validate argument transformation for
condition/legacyNX/XXplusfpha, and to run version-gated client integration checks forfphabehavior and interactions withNX/XXconditions.Reviewed by Cursor Bugbot for commit eee134e. Bugbot is set up for automated code reviews on this repo. Configure here.