feat(client): add XNACK command with options and tests#3238
Merged
nkaradzhov merged 2 commits intoredis:masterfrom Apr 22, 2026
Merged
feat(client): add XNACK command with options and tests#3238nkaradzhov merged 2 commits intoredis:masterfrom
nkaradzhov merged 2 commits intoredis:masterfrom
Conversation
PavelPashov
approved these changes
Apr 22, 2026
| }); | ||
| }); | ||
|
|
||
| testUtils.testWithClient('xNack', async client => { |
Contributor
There was a problem hiding this comment.
Does it make sense to test with cluster as well?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Checklist
npm testpass with this change (including linting)?Note
Low Risk
Low risk: additive new command wiring plus tests; only touches the exported command registry and should not affect existing command behavior.
Overview
Adds client support for Redis 8.8
XNACK, exposing it asxNack/XNACKwith support forSILENT/FAIL/FATALmodes, variadic IDs encoded viaIDS <len>, and optionalRETRYCOUNT/FORCEflags.Includes unit tests for argument serialization and an integration test that exercises
xNackagainst a real server (gated on Docker Redis >= 8.8), and wires the command into the centralcommands/index.tsexport map.Reviewed by Cursor Bugbot for commit 970be65. Bugbot is set up for automated code reviews on this repo. Configure here.