fix: expose stack modules on pool type#3267
Merged
nkaradzhov merged 1 commit intoMay 12, 2026
Merged
Conversation
nkaradzhov
approved these changes
May 12, 2026
Collaborator
|
Thanks @raashish1601, looking good! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
createClientPool()from theredispackage already injects the default Redis Stack modules, but the package only re-exportedRedisClientPoolTypefrom@redis/client, whose default module set is empty. That meant code annotating a pool asRedisClientPoolTypelost thejsonandftnamespaces.This adds a
redispackage-levelRedisClientPoolTypealias with the same default module set asRedisClientTypeandcreateClientPool().Fixes #3149.
Validation
npm run buildnpx tsc --noEmit --module NodeNext --moduleResolution NodeNext --target ES2022 --lib ES2023 --strict --skipLibCheck --esModuleInterop .tmp-pool-type-test.tsnpm run lintNote
Low Risk
Low risk type-only change that adjusts exported typings for
RedisClientPoolTypeto match actual module injection behavior; no runtime logic changes.Overview
Aligns the
redispackage’s pool typings withcreateClientPool()behavior by adding a package-levelRedisClientPoolTypealias whose default generic module set includes the Redis Stack modules (e.g.json,ft,ts, Bloom).This prevents type annotations using
RedisClientPoolTypefrom losing the Stack module namespaces compared to the existingRedisClientType/createClientPool()defaults.Reviewed by Cursor Bugbot for commit d6a5f0b. Bugbot is set up for automated code reviews on this repo. Configure here.