-
Notifications
You must be signed in to change notification settings - Fork 122
Open
Labels
Milestone
Description
Problem
pyproject.toml claims Python 3.8 support (python = ">=3.8,<4.0"), but the code fails to import on Python 3.8:
from typing import Annotated # ImportError on Python 3.8Options
Option 1: Drop Python 3.8 (Recommended)
- Python 3.8 reached end-of-life in October 2024
- Update
pyproject.tomltopython = ">=3.9,<4.0" - Remove Python 3.8 from CI matrix (already not tested)
- Clean approach for 1.0 release
Option 2: Fix imports for 3.8 compatibility
- Use
from typing_extensions import Annotatedwith fallback - More maintenance burden for an EOL Python version
Related
- redis-om 1.0.3b0: python 3.8 is still supported in pyproject.toml but typing fails #706 (original user report)
Recommendation
Drop Python 3.8 support for the 1.0 release. This is standard practice for a major release and Python 3.8 is EOL.