Fix Python 3.14 dict iteration error in JsonModel #764
+208
−3
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #763 - Python 3.14 compatibility for
JsonModel.schema_for_fields().The Problem
In Python 3.14, iterating over
cls.__dict__.items()directly can raise:This occurs during class construction when Pydantic is still modifying the class namespace.
The Solution
Instead of copying the entire
__dict__before iteration (which wastes memory), this PR iterates overcls.__annotations__keys and looks up each value in__dict__individually:This approach:
__dict__Tests Added
Comprehensive test coverage for
schema_for_fields()edge cases: