Skip to content

REPLICA commands missing in Sentinel #3817

@minrk

Description

@minrk

Version: redis-py 5.0.8 , redis-server 7.2.5

Platform: macOS

Description:

Redis 5.0 deprecated SLAVE in most contexts in favor of REPLICA. The Python API and docs reflect this in many places, but it's still missing in some, particularly the Sentinel APIs, which do not implement the REPLICA commands or method names, only using the deprecated names.

I would expect these methods/classes to be defined, in order to match the redis server Sentinel API and documentation.

  • Sentinel.replica_for
  • .discover_replicas
  • .filter_replicas
  • SentinelConnectionPool.rotate_replicas
  • redis.sentinel.ReplicaNotFound

Also related:

  • Redis.client_kill_filter appears to not accept type=REPLICA

(reopening #3371, which was erroneously closed by a bot)

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions