Adding maintenance notification configuration to cluster client. Integration with testing helper proxy server. #3844
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds maintenance notification configuration support to the Redis cluster client, enabling applications to receive and handle maintenance events from Redis clusters. It also introduces a proxy-based testing infrastructure to simulate and validate maintenance notification handling.
- Adds
maint_notifications_configparameter toRedisClusterand propagates it through the cluster node initialization - Introduces comprehensive unit tests for maintenance notification classes and handlers
- Adds integration test helpers using a proxy server for testing notification behavior
- Updates Docker infrastructure to include proxy services for testing
Reviewed Changes
Copilot reviewed 6 out of 8 changed files in this pull request and generated 6 comments.
Show a summary per file
| File | Description |
|---|---|
| redis/cluster.py | Adds maint_notifications_config parameter to RedisCluster and NodesManager, propagates config to all cluster nodes |
| redis/client.py | Fixes grammar in documentation comment ("configuration" -> "configures") |
| tests/maint_notifications/test_maint_notifications.py | Comprehensive unit tests for notification classes, config, and handlers (897 lines) |
| tests/maint_notifications/test_cluster_maint_notifications_handling.py | Integration tests for cluster maintenance notification handling with proxy |
| tests/maint_notifications/proxy_server_helpers.py | Helper classes for proxy-based testing infrastructure |
| tests/maint_notifications/test_maint_notifications_handling.py | Documentation correction in docstring |
| docker-compose.yml | Adds proxy services and updates image tags for testing infrastructure |
| .gitignore | Adds /experimenting/ directory to ignore list |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
tests/maint_notifications/test_cluster_maint_notifications_handling.py
Outdated
Show resolved
Hide resolved
petyaslavova
force-pushed
the
ps_add_maint_notifications_config_to_cluster_client_add_srv_proxy
branch
from
ce738e3 to
4c06962
Compare
vladvildanov
requested changes
Nov 17, 2025
vladvildanov
approved these changes
Nov 17, 2025
petyaslavova
merged commit f57ea65
into
feat/hitless_upgrade_sync_cluster_client
4 checks passed
petyaslavova
deleted the
ps_add_maint_notifications_config_to_cluster_client_add_srv_proxy
branch
petyaslavova
added a commit
that referenced
this pull request
Nov 17, 2025
…gration with testing helper proxy server. (#3844) * Adding maint_notifications_config to RedisCluster's NodesManager * Adding Redis Proxy integration * Migrating test proxy helper to use custom https client
petyaslavova
added a commit
that referenced
this pull request
Nov 20, 2025
…gration with testing helper proxy server. (#3844) * Adding maint_notifications_config to RedisCluster's NodesManager * Adding Redis Proxy integration * Migrating test proxy helper to use custom https client
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request check-list
Please make sure to review and check all of these items:
NOTE: these things are not required to open a PR and can be done
afterwards / while the PR is open.
Description of change
Please provide a description of the change here.