OpenAI API client upgrade and code migration #126
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bsbodden
force-pushed
the
bsb/open-ai-api-upgrade
branch
6 times, most recently
from
5ed37bf to
8ad92b5
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #126 +/- ##
==========================================
+ Coverage 82.48% 89.39% +6.90%
==========================================
Files 25 25
Lines 1479 1480 +1
==========================================
+ Hits 1220 1323 +103
+ Misses 259 157 -102 ☔ View full report in Codecov by Sentry. |
bsbodden
force-pushed
the
bsb/open-ai-api-upgrade
branch
6 times, most recently
from
1dc0530 to
f077e0f
Compare
tylerhutcherson
requested changes
Mar 1, 2024
bsbodden
force-pushed
the
bsb/open-ai-api-upgrade
branch
from
f077e0f to
aeed0b5
Compare
tylerhutcherson
approved these changes
Mar 1, 2024
Collaborator
|
Once CI passes, good to go. Will merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upgrade OpenAI Python lib to >1.0.0 and migrates the code following openai/openai-python#742 (comment)
Also, conditional skipping logic for vectorizers has been fixed (it was always skipping)