Skip to content

Conversation

@justin-cechmanek
Copy link
Collaborator

No description provided.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR automates the conversion of vector arrays to byte strings in the Vector object, simplifying the API by removing the need for manual conversion in MultiVectorQuery.

  • Adds a model validator to Vector class that automatically converts float arrays to byte strings based on the specified dtype
  • Simplifies MultiVectorQuery.params by removing redundant conversion logic since vectors are now pre-converted
  • Adds comprehensive test coverage for both float-to-bytes conversion and direct bytes input scenarios

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

File Description
redisvl/query/aggregate.py Added model validator to Vector class for automatic byte conversion; simplified MultiVectorQuery.params method
tests/unit/test_aggregation_types.py Added unit tests verifying Vector class handles both float arrays and byte strings correctly
tests/integration/test_aggregation.py Added integration test for MultiVectorQuery accepting pre-converted byte strings

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Copy link
Collaborator

@nkanu17 nkanu17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me except for the unused import!

I am surprised that the linter tests are not catching this

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated no new comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@justin-cechmanek justin-cechmanek merged commit 139eb64 into main Oct 24, 2025
38 checks passed
@justin-cechmanek justin-cechmanek deleted the feat/RAAE-1097/bytes-in-vector-class branch October 24, 2025 22:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants