Skip to content

Conversation

@vishal-bala
Copy link
Collaborator

@vishal-bala vishal-bala commented Dec 2, 2025

Closes #443

This PR updates the logger configuration helper for RedisVL to avoid configuring the root logger via logging.basicConfig. That operation was interfering with user-configured loggers, causing app logs to be emitted multiple times and making it trickier to hide RedisVL logs when running in production.

In its place, we now configure a NullHandler (mainly to avoid issues with loggers not having any handlers configured). This means that any RedisVL usage that expects logs to have a specific format must now configure that format for itself.

@vishal-bala vishal-bala self-assigned this Dec 2, 2025
@jit-ci
Copy link

jit-ci bot commented Dec 2, 2025

Hi, I’m Jit, a friendly security platform designed to help developers build secure applications from day zero with an MVS (Minimal viable security) mindset.

In case there are security findings, they will be communicated to you as a comment inside the PR.

Hope you’ll enjoy using Jit.

Questions? Comments? Want to learn more? Get in touch with us.

Copy link
Collaborator

@tylerhutcherson tylerhutcherson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense. Any way to test this somehow? The issuer gave a reproducer that we could use to turn into a test case possibly capturing the stdout and comparing

@vishal-bala
Copy link
Collaborator Author

@tylerhutcherson Yup! There was an existing test for roughly the same case that I extended to test that we don't emit duplicated logs anymore (it's very similar to the reproducing steps the issuer mentioned - see changes to logger_interference_checker.py and the associated test)

@vishal-bala vishal-bala merged commit d992f8f into main Dec 3, 2025
38 checks passed
@vishal-bala vishal-bala deleted the bug/RAAE-1234/logger-config branch December 3, 2025 13:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Logging configuration affects application loggers

3 participants