Avoid configuring root logger in RedisVL #445
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #443
This PR updates the logger configuration helper for RedisVL to avoid configuring the root logger via
logging.basicConfig. That operation was interfering with user-configured loggers, causing app logs to be emitted multiple times and making it trickier to hide RedisVL logs when running in production.In its place, we now configure a
NullHandler(mainly to avoid issues with loggers not having any handlers configured). This means that any RedisVL usage that expects logs to have a specific format must now configure that format for itself.