Fix wrong argv index in xinfoReplyWithStreamInfo for slot alloc size tracking#15037
Merged
sundb merged 1 commit intoredis:unstablefrom Apr 14, 2026
Merged
Conversation
🤖 Augment PR SummarySummary: Fixes per-slot memory tracking in Changes:
🤖 Was this summary useful? React with 👍 or 👎 |
Collaborator
Author
ReproduceReport: |
skaslev
approved these changes
Apr 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
xinfoReplyWithStreamInfopassed the wrong key(c->argv[1]) instead ofc->argv[2]toupdateSlotAllocSizewhen updating per-slot memory tracking.Fix by passing the key explicitly to
xinfoReplyWithStreamInfoinstead of relying on a hardcoded argv index.Also, add the
-DDEBUG_ASSERTIONSflag to the test-ubuntu-jemalloc CI to cover this debug assertion.The
xinfocommand argv layout is:Note
Medium Risk
Touches per-slot memory tracking for
XINFO STREAM, which can affect cluster slot memory accounting/metrics if incorrect, but the change is small and localized. CI build flags are expanded to run additional debug assertions that may surface new failures.Overview
Fixes
XINFO STREAMper-slot memory tracking by passing the actual streamkeyintoxinfoReplyWithStreamInfoand using it (instead of a hardcodedargvindex) when callingupdateSlotAllocSize.Updates the
test-ubuntu-jemallocDaily CI job to compile with-DDEBUG_ASSERTIONSto exercise related debug checks during tests.Reviewed by Cursor Bugbot for commit dde5f89. Bugbot is set up for automated code reviews on this repo. Configure here.