Skip to content

Add go.mod for rueidisaside and om packages#456

Merged
rueian merged 2 commits intoredis:mainfrom
DestroyerAlpha:movedependency
Jan 24, 2024
Merged

Add go.mod for rueidisaside and om packages#456
rueian merged 2 commits intoredis:mainfrom
DestroyerAlpha:movedependency

Conversation

@DestroyerAlpha
Copy link
Copy Markdown
Contributor

Solves #452

Comment thread om/go.mod

require (
github.com/oklog/ulid/v2 v2.1.0
github.com/redis/rueidis v1.0.27
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should this be replace github.com/redis/rueidis => ../ instead?

@DestroyerAlpha
Copy link
Copy Markdown
Contributor Author

Made the change, go mod tidy added github.com/redis/rueidis v1.0.27 anyways

@DestroyerAlpha DestroyerAlpha requested a review from rueian January 24, 2024 05:06
@codecov-commenter
Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (eb3729b) 96.02% compared to head (d26b0eb) 95.98%.
Report is 1 commits behind head on main.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #456      +/-   ##
==========================================
- Coverage   96.02%   95.98%   -0.05%     
==========================================
  Files          75       67       -8     
  Lines       32104    31549     -555     
==========================================
- Hits        30829    30282     -547     
+ Misses       1090     1085       -5     
+ Partials      185      182       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rueian rueian merged commit e869b8b into redis:main Jan 24, 2024
@DestroyerAlpha DestroyerAlpha deleted the movedependency branch January 25, 2024 07:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants