refactor: move uber/mock dependency to submodules#465
Merged
rueian merged 3 commits intoredis:mainfrom Feb 10, 2024
Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #465 +/- ##
==========================================
- Coverage 95.71% 95.66% -0.06%
==========================================
Files 67 63 -4
Lines 32119 31765 -354
==========================================
- Hits 30744 30387 -357
- Misses 1182 1183 +1
- Partials 193 195 +2 ☔ View full report in Codecov by Sentry. |
rueian
reviewed
Feb 10, 2024
Collaborator
rueian
left a comment
rueian
left a comment
There was a problem hiding this comment.
Hi @erdemtuna,
Many thanks! Just that those module names should be fully specified.
Co-authored-by: Rueian <rueiancsie@gmail.com>
Co-authored-by: Rueian <rueiancsie@gmail.com>
Contributor
Author
|
missed those, thank you @rueian |
Collaborator
|
LGTM. Thanks again! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello, this change addresses #453.