Skip to content

fix: respect rueidisotel.MetricAttrs options, and avoid copy them repeatedly#471

Merged
rueian merged 1 commit intomainfrom
fix-463-metrics-attrs
Feb 20, 2024
Merged

fix: respect rueidisotel.MetricAttrs options, and avoid copy them repeatedly#471
rueian merged 1 commit intomainfrom
fix-463-metrics-attrs

Conversation

@rueian
Copy link
Copy Markdown
Collaborator

@rueian rueian commented Feb 17, 2024

Fixes #463

@rueian rueian added the bug Something isn't working label Feb 17, 2024
@codecov-commenter
Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (3d21559) 95.66% compared to head (f3cfb13) 95.65%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #471      +/-   ##
==========================================
- Coverage   95.66%   95.65%   -0.01%     
==========================================
  Files          63       63              
  Lines       31765    31765              
==========================================
- Hits        30387    30384       -3     
- Misses       1184     1185       +1     
- Partials      194      196       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rueian rueian merged commit 0b3eda8 into main Feb 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

MetricAttrs() does not add KeyValue attributes to the metrics

2 participants