Refactor: add baseCmd to go-redis adaptor commands#473
Merged
rueian merged 1 commit intoredis:mainfrom Mar 3, 2024
Merged
Conversation
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #473 +/- ##
==========================================
- Coverage 95.66% 95.40% -0.26%
==========================================
Files 67 67
Lines 31824 31644 -180
==========================================
- Hits 30443 30189 -254
- Misses 1185 1259 +74
Partials 196 196 ☔ View full report in Codecov by Sentry. |
Collaborator
|
Hi @unknowntpo, We just had a ci fix on the main branch. Please rebase on the main branch to run your tests again. |
There are some Commands that can't use baseCmd due to incompatible method signature for (*Command).SetVal, (*Command).Val, (*Command).Result. e.g. KeyValuesCmd, ZSliceWithKeyCmd, XAutoClaimCmd, XAutoClaimJustIDCmd.
unknowntpo
force-pushed
the
refactor-add-baseCmd
branch
from
34d7009 to
cbed500
Compare
Contributor
Author
|
@rueian PR is rebased. |
rueian
approved these changes
Mar 3, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR add
baseCmdtogo-redisadaptor commands.Note that there are some Commands that can't use
baseCmddue to incompatible methodsignature for
(*Command).SetVal,(*Command).Val,(*Command).Result.e.g.
KeyValuesCmd,ZSliceWithKeyCmd,XAutoClaimCmd,XAutoClaimJustIDCmd.