add IsBusyGroup() to rueidis.RedisError#485
Merged
rueian merged 3 commits intoredis:mainfrom Mar 1, 2024
Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #485 +/- ##
==========================================
- Coverage 95.72% 95.71% -0.01%
==========================================
Files 77 77
Lines 33084 33091 +7
==========================================
+ Hits 31669 31673 +4
- Misses 1210 1211 +1
- Partials 205 207 +2 ☔ View full report in Codecov by Sentry. |
Collaborator
|
Cool! Thanks @jhq0113! Would you like to also add a global helper err := client.Do(context.Background(), client.B().XgroupCreate().Key("").Group("").Id("").Build()).Error()
if rueidis.IsRedisBusyGroup(err) {
// ...
} |
Contributor
Author
|
Yes, I do |
rueian
approved these changes
Mar 1, 2024
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When executing the
XGROUP CREATE <key> <group> <id>command, if group already exists, Redis will return BUSYGROUP..., Generally, the caller BUSYGROUP needs to distinguish from other errors, and adding this judgment can facilitate differentiation from other errors