fix: use POSIX character class in sed for macOS compatibility#2
Merged
fix: use POSIX character class in sed for macOS compatibility#2
Conversation
Replace GNU-only \s with [[:space:]] in sed expressions so that uv_version extraction and checksum lookup work on BSD sed (macOS). Without this, \s silently fails, uv_version resolves to empty, and the download URL 404s. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
There was a problem hiding this comment.
Orca Security Scan Summary
| Status | Check | Issues by priority | |
|---|---|---|---|
| Infrastructure as Code | View in Orca | ||
| SAST | View in Orca | ||
| Secrets | View in Orca | ||
| Vulnerabilities | View in Orca |
codemedic
approved these changes
Mar 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
\swith[[:space:]]in twosed -Eexpressions ininstall.sh\s, causinguv_versionto resolve to empty and the download URL to 404Test plan
install.shon macOS (BSD sed) — uv downloads successfullyinstall.shon Linux (GNU sed) — uv downloads successfully🤖 Generated with Claude Code