Skip to content

Conversation

@takenory
Copy link
Collaborator

This pull request fixes an issue where the IP address filter menu item was not marked as selected in the admin menu when accessing the filter settings screen.

Changes

  • Added self.menu_item :redmine_ip_filter to FilterRulesController to ensure proper menu highlighting
  • Added a functional test to verify that the correct admin menu item is selected

Notes

  • Verified that the IP address filter menu item is correctly highlighted when visiting the filter settings page
  • All tests, including the new one, pass successfully

Copy link
Contributor

@hidakatsuya hidakatsuya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@takenory takenory merged commit 4e94786 into redmica:master Jul 29, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants