Compatible with Rails 6: zeitwerk and search path #807
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is to cope with rails autoloading : zeitwerk. I was unable to keep hrack subfolders as is per zeitweirk ended up trying to load Hrack::Lib::Hrack::Lib for the plugin config/routes.rb call to
mount Hrack::Bundle.new({}), at: 'githooks/post-receive/:type/:projectid', via: [:post]. Probably a bug in zeitwerk when the a folder has its own name in one of its subfolder.If I rename one of the subfolder and the caller Hrack by Hracp it works. So my above deduction.
Otherwise I mostly synchronize the module hierarchy to the folder hierarchy per zeitwerk requirements. I keep the code out of the module if it was not already enclosed by a module.
I also add plugin lib to the LOAD_PATH.