Fix ruby3 #808
Closed
Fix ruby3 #808
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ents Ruby 3.0 does not implicitly destructure a Hash into keyword arguments if it was the last parameter to a method call. Also handle explicitely delegate keyword arguments.
Seems we only want an optional hash not keyword arguments so remove the double sprat and set a default empty hash value.
Merged
Collaborator
|
Thank you for your work so far. It has been superseded by #815 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moslty cope with automatic hash to keyword arguments and keyword arguments to hash deprecation by adding double sprat to the callers as was already done on this repository. Plus cope with keyword arguments delegation.
Plus replace a hash to keywords argument by a positional optional hahs argument.
Though this is fine I believe we never intended to make use of a hash to keyword arguments idiom. The use case is only a positional optional hash which is better done with a parameter as
, options = {}than, **options.But this will require to switch more code than is done in this patch. Maybe a task for later.
I did replace the double sprat by a positional optional hash parameter once in this patchset but this was because it was a specialization of a redmine signature that was already using the
, options = {}and thus the double sprat was breaking when called by the redmine code.