Redmine5 finalization: modules loading #816
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The block registered by redmine_git_hosting plugin to Rails.application.config.to_prepare wasn't actually called (at least, in a test context). This appears to be due to the fact that the plugin's init.rb file is already loaded from within a Rails "to_prepare" initialization event block. Cf. Redmine's PluginLoader class and its "load" method defined in lib/redmine/plugin_loader.rb file: a Rails "to_prepare" block iterates over all plugin directory to find and load an "init.rb" file. As a consequence, there's no need to rewrap some code from the plugin's init.rb file into a Rails "to_prepare" event handling block.
Maybe due to upgrading to Ruby 3.x, the code of these modules couldn't
be loaded anymore, due to an infinite loading loop.
For instance, for the Commands module:
* Loading of commands.rb is triggered,
* As its first instruction, the module extends Commands::Base,
* So the loading of commands/base.rb is triggered,
* But then, in that file, the Base module is included in the
Commands module, which has to be loaded first,
* And so, we're back to the beginning...
To work around this, the "extend Xx::Xx" instructions are moved to the
submodules themselves, so that each submodule can be loaded
independently and add its contributions to the main module (Commands or
Config).
dosyfier
force-pushed
the
redmine5
branch
2 times, most recently
from
b838f30 to
f628fb9
Compare
After upgrading to Ruby 3.1, following error raises when running
redmine_git_hosting tests depending on loading a fixture based on a YAML
file:
Psych::DisallowedClass:
Tried to load unspecified class: Time
Collaborator
|
This is great, thank you ! Is there anything else you would like to do before we cut a release ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request is an appendix to #815 (which was prematurely merged).
It concludes the plugin migration towards Redmine 5 initiated by #813.
It corrects:
RedmineGitHosting.load_plugin!, which wasn't called anymore;CommandsandConfigmodules, which failed in an infinite loading loop.