-
Notifications
You must be signed in to change notification settings - Fork 2
Add new overlays #24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add new overlays #24
Conversation
|
Important Review skippedAuto incremental reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the 📝 WalkthroughWalkthroughAdds two overlay YAML files:
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Suggested reviewers
Pre-merge checks and finishing touches❌ Failed checks (1 warning, 1 inconclusive)
✅ Passed checks (3 passed)
Comment |
|
ℹ️ API content change detected: No structural change, nothing to display.
|
2fa6b2d to
c50fead
Compare
| description: |- | ||
| The type of resource (topic, consumer group, etc.) this | ||
| ACL targets. | ||
| enum: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just to keep in mind - we'll need to manually update this list if the Cloud team add more enums to the source.
This pull request introduces targeted updates to the API schema overlays and response examples for the cloud control plane and data plane. The changes focus on improving user-facing clarity, enforcing stricter schema validation, and correcting resource identifiers in error metadata.
API schema and response example improvements:
Clusterobject to use a more descriptive value (NETWORK_ACCESS_MODE_PUBLIC) for theapi_gateway_accessfield, replacing the previous unspecified mode.Schema validation and enum restrictions:
RESOURCE_TYPE_ANYas a valid option for theresource_typefield in theCreateACLRequestschema, ensuring only specific resource types are allowed. The enum is now explicitly defined in a new restricted componentCreateACLResourceTypeand the$refis updated to point to the restricted schema.Resolves https://redpandadata.atlassian.net/browse/DOC-1657