Skip to content

Cloud Terraform provider beta#11

Merged
micheleRP merged 14 commits intomainfrom
2147-Cloud-Terraform-provider-beta
Oct 10, 2024
Merged

Cloud Terraform provider beta#11
micheleRP merged 14 commits intomainfrom
2147-Cloud-Terraform-provider-beta

Conversation

@micheleRP
Copy link
Copy Markdown
Contributor

@micheleRP micheleRP commented Aug 1, 2024

Description

Resolves https://github.com/redpanda-data/documentation-private/issues/2147
Review deadline: Aug 23, expecting this feature to land mid-Sept.

Because Cloud docs moved into a separate repo, I had to move https://github.com/redpanda-data/docs/pull/607/files into this new PR.

Page previews

What's New
Redpanda Terraform Provider

Checks

  • New feature
  • Content gap
  • Support Follow-up
  • Small fix (typos, links, copyedits, etc)

@micheleRP micheleRP requested a review from a team as a code owner August 1, 2024 20:47
@netlify
Copy link
Copy Markdown

netlify Bot commented Aug 1, 2024

Deploy Preview for rp-cloud ready!

Name Link
🔨 Latest commit 534c851
🔍 Latest deploy log https://app.netlify.com/sites/rp-cloud/deploys/67083b1df9dae8000873d23b
😎 Deploy Preview https://deploy-preview-11--rp-cloud.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Copy Markdown
Member

@gene-redpanda gene-redpanda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Comment thread modules/develop/pages/terraform-provider.adoc Outdated
--
======

. For sample configurations, see the https://registry.terraform.io/providers/redpanda-data/redpanda/latest/docs[Redpanda Terraform provider docs^]. *NOTE TO REVIEWERS: This linked doc needs update for beta*
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there is no linked doc?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gene-redpanda I'm thinking this doc should be updated from alpha to beta

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh sure, we can do that next release.

@micheleRP micheleRP force-pushed the 2147-Cloud-Terraform-provider-beta branch from 645cebe to 25c197d Compare September 5, 2024 15:21
Comment thread modules/develop/pages/terraform-provider.adoc Outdated
@david-yu
Copy link
Copy Markdown
Contributor

Hi @micheleRP

There are a few more possibilities but I'm curious what your thoughts are about documenting terraform workflows that are possible via: https://registry.terraform.io/providers/redpanda-data/redpanda/latest/docs/resources/user

  1. Is it possible to somehow host a github repo that has terraform config files for standing up a BYOC, Dedicated, and Serverless Cluster.
  2. Show topic creation and demonstrate producing and consuming messages from the topic after creating the topic.
  3. Show ACL creation using Terrform provider.
  4. Show User creation using Terraform provider.

Comment thread modules/develop/pages/terraform-provider.adoc Outdated
+
[tabs]
======
Static credentials::
Copy link
Copy Markdown
Contributor

@david-yu david-yu Sep 12, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we place a warning that this is not recommended for production? Typically folks would want to set these using environment variables or retrieve via some KMS system.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@david-yu My understanding is that this whole feature is going out as beta, and beta is not considered production-ready... so I don't think we want an additional "not recommended for production" for this section. If we don't recommend static credentials, should we just remove that option and say to set environment variables?

@micheleRP micheleRP force-pushed the 2147-Cloud-Terraform-provider-beta branch from 25c197d to e8017ba Compare September 12, 2024 22:58
Comment thread modules/develop/pages/terraform-provider.adoc Outdated
Comment thread modules/develop/pages/terraform-provider.adoc Outdated
Comment thread modules/develop/pages/terraform-provider.adoc Outdated
Comment thread modules/develop/pages/terraform-provider.adoc Outdated
Copy link
Copy Markdown
Contributor

@Feediver1 Feediver1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

micheleRP and others added 7 commits September 27, 2024 14:51
Co-authored-by: Joyce Fee <102751339+Feediver1@users.noreply.github.com>
Co-authored-by: Joyce Fee <102751339+Feediver1@users.noreply.github.com>
Co-authored-by: Joyce Fee <102751339+Feediver1@users.noreply.github.com>
required_providers {
redpanda = {
source = "redpanda-data/redpanda"
version = "~> 0.8"
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we maintain this version somewhere, or even fetch it dinamically? cc @JakeSCahill

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@micheleRP We should now bump this to 0.9.0

Copy link
Copy Markdown
Contributor

@david-yu david-yu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved on my end. Thank you for the finishing touches!

@micheleRP micheleRP merged commit 3cae844 into main Oct 10, 2024
@micheleRP micheleRP deleted the 2147-Cloud-Terraform-provider-beta branch October 10, 2024 21:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants