-
Notifications
You must be signed in to change notification settings - Fork 4
DOC-783 Dedicated Limited availability #139
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
✅ Deploy Preview for rp-cloud ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
JakeSCahill
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Just one clarifying question about the use of built-in environment variables.
| * `<bootstrap-server-url>`: The bootstrap server address you copied in <<before-you-start,Before you start>>. | ||
| * `<cluster-password>`: The password of the connect user you set up in <<before-you-start,Before you start>>. | ||
| * Replace `<cluster-password>` with the password of the connect user you set up in <<before-you-start,Before you start>>. To avoid exposing secrets, Redpanda Connect also supports secret variables. For more information, see xref:develop:connect/configuration/secret-management.adoc[Manage Secrets]. | ||
| * `${REDPANDA_BROKERS}` is a contextual variable that references the bootstrap server address of your cluster. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we clarify that all pipelines running in Cloud clusters have access to this variable and that you don't need to do anything?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are there other variables?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@JakeSCahill Yes, there are other variables. There is a ticket open for this and I will complete it as soon as I can after the release: https://redpandadata.atlassian.net/browse/DOC-621.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've added an extra sentence to clarify for the moment.
Description
Resolves DOC-783
Review deadline: 29 November
Updates RP Connect documentation for Dedicated LA launch. Update to What's new will be in a separate PR.
Link to the Manage Secrets page will not work until a separate PR is merged.
Page previews
Checks