-
Notifications
You must be signed in to change notification settings - Fork 4
DOC-1311 Add google_drive_list_labels processor to cloud #292
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DOC-1311 Add google_drive_list_labels processor to cloud #292
Conversation
✅ Deploy Preview for rp-cloud ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
Important Review skippedAuto incremental reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the 📝 WalkthroughWalkthroughThe changes update the Antora playbook configuration to source documentation from a specific feature branch instead of the main branch. A new navigation entry is added for the "google_drive_list_labels" processor under the processors section. Additionally, a new AsciiDoc documentation page for the "google_drive_list_labels" processor is created, which includes content from an external source file using an include directive. No changes to code or exported entities are present; all modifications are related to documentation structure and content. Sequence Diagram(s)sequenceDiagram
participant User
participant Antora Playbook
participant GitHub Repo (rp-connect-docs)
participant Documentation Site
User->>Antora Playbook: Requests documentation build
Antora Playbook->>GitHub Repo (rp-connect-docs): Fetches content from DOC-1311_Add_google_drive_list_labels_processor branch
Antora Playbook->>Documentation Site: Generates site with new processor doc and nav entry
User->>Documentation Site: Accesses "google_drive_list_labels" processor documentation
Assessment against linked issues
Suggested reviewers
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (2)
local-antora-playbook.yml (1)
23-23: Reminder: Revert branch override before mergingThis change points the local playbook to your feature branch for previewing the new processor docs. Make sure to revert this back to
HEAD(or remove the override) before merging into the main branch to avoid breaking CI or production builds.modules/develop/pages/connect/components/processors/google_drive_list_labels.adoc (1)
1-3: Use a human-readable, title-cased page headingMost AsciiDoc pages use natural language titles rather than slugs. Consider updating the title to improve readability:
- = google_drive_list_labels + = Google Drive List Labels
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (3)
local-antora-playbook.yml(1 hunks)modules/ROOT/nav.adoc(1 hunks)modules/develop/pages/connect/components/processors/google_drive_list_labels.adoc(1 hunks)
🔇 Additional comments (1)
modules/ROOT/nav.adoc (1)
219-219: New navigation entry looks correctThe
google_drive_list_labelsprocessor has been added under the processors section and follows the existing alphabetical ordering. The xref path matches the new page location.
Description
Resolves: DOC-1311
Review deadline: 14 May
This pull request introduces a new processor,
google_drive_list_labels, to the documentation and updates the relevant configuration and navigation files to include it. The most important changes are grouped below by theme.Documentation Updates:
google_drive_list_labelsprocessor inmodules/develop/pages/connect/components/processors/google_drive_list_labels.adoc. This includes a page alias and content sourced from a single source file.Configuration Changes:
branchesvalue inlocal-antora-playbook.ymlfor therp-connect-docsrepository to point to theDOC-1311_Add_google_drive_list_labels_processorbranch.Navigation Updates:
google_drive_list_labelsprocessor inmodules/ROOT/nav.adoc.Page previews
google_drive_list_labelsprocessorChecks