Skip to content

Add migration pages to Cloud#511

Merged
kbatuigas merged 2 commits intomainfrom
add-new-iceberg-migration-doc-to-cloud
Feb 28, 2026
Merged

Add migration pages to Cloud#511
kbatuigas merged 2 commits intomainfrom
add-new-iceberg-migration-doc-to-cloud

Conversation

@kbatuigas
Copy link
Contributor

Description

Add redpanda-data/docs#1579 to Cloud.

Resolves https://github.com/redpanda-data/documentation-private/issues/
Review deadline:

Page previews

Checks

  • New feature
  • Content gap
  • Support Follow-up
  • Small fix (typos, links, copyedits, etc)

@kbatuigas kbatuigas requested a review from a team as a code owner February 26, 2026 22:09
@netlify
Copy link

netlify bot commented Feb 26, 2026

Deploy Preview for rp-cloud ready!

Name Link
🔨 Latest commit 3841a1d
🔍 Latest deploy log https://app.netlify.com/projects/rp-cloud/deploys/69a269ad4fd0ad000805dcf7
😎 Deploy Preview https://deploy-preview-511--rp-cloud.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Feb 26, 2026

Important

Review skipped

Auto incremental reviews are disabled on this repository.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
📝 Walkthrough

Walkthrough

This pull request updates Antora playbook configuration to point to a specific feature branch (DOC-1590-migration-guidance-for-existing-iceberg-tables-to) instead of the main branch, adds a new navigation entry in the Iceberg topics section, and introduces a new documentation page describing the migration process for Iceberg Topics, including learning objectives and implementation guidance.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Possibly related PRs

  • Add Databricks pages in Cloud #321: Applies identical edit patterns to local-antora-playbook.yml (replacing main with a feature DOC branch), adds a new Iceberg nav entry, and introduces a new Iceberg documentation page.
  • Add new Iceberg modes doc in Cloud #260: Updates playbook branch configuration, adds an Iceberg nav entry, and introduces a new Iceberg documentation page with matching structural changes.
  • Add Iceberg Snowflake doc to Cloud #302: Makes parallel edits to Antora playbook configuration (replacing main with a DOC-branch), adds a new Iceberg nav entry, and introduces a new Iceberg documentation page.

Suggested reviewers

  • paulohtb6
  • mattschumpert
  • simon0191
🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The title 'Add migration pages to Cloud' accurately reflects the main change: adding a new migration documentation page (migrate-to-iceberg-topics.adoc) to the Cloud repository alongside related navigation and configuration updates.
Description check ✅ Passed The PR description follows the template structure with all required sections present, but contains unfilled placeholders (issue number, review deadline, and page previews) that should be completed for full clarity.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch add-new-iceberg-migration-doc-to-cloud

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Inline comments:
In `@local-antora-playbook.yml`:
- Line 18: Update the branches list back to include the main branch: in the YAML
key named branches replace the feature branch string
'DOC-1590-migration-guidance-for-existing-iceberg-tables-to' with 'main'
(preserving the other entries like v/*, shared, site-search), and ensure the
corresponding PR in the redpanda-data/documentation repo is merged first so
single-sourcing remains correct before merging this change.

ℹ️ Review info

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Disabled knowledge base sources:

  • Jira integration is disabled

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between 6f5783d and 0c59adf.

📒 Files selected for processing (3)
  • local-antora-playbook.yml
  • modules/ROOT/nav.adoc
  • modules/manage/pages/iceberg/migrate-to-iceberg-topics.adoc

branches: HEAD
- url: https://github.com/redpanda-data/documentation
branches: [main, v/*, shared, site-search]
branches: ['DOC-1590-migration-guidance-for-existing-iceberg-tables-to', v/*, shared, site-search]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟠 Major

Revert branch change before merging.

The main branch has been removed from the branches list and replaced with the feature branch DOC-1590-migration-guidance-for-existing-iceberg-tables-to. This is appropriate for local preview builds, but per the cross-repository single sourcing pattern used in this documentation system, the playbook should be reverted to include main before merging this PR.

Ensure the corresponding PR in the redpanda-data/documentation repo is merged first, then restore:

-    branches: ['DOC-1590-migration-guidance-for-existing-iceberg-tables-to', v/*, shared, site-search]
+    branches: [main, v/*, shared, site-search]

Based on learnings: "The playbook is reverted to main before merging. This cross-repository single sourcing pattern is commonly used."

📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
branches: ['DOC-1590-migration-guidance-for-existing-iceberg-tables-to', v/*, shared, site-search]
branches: [main, v/*, shared, site-search]
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.

In `@local-antora-playbook.yml` at line 18, Update the branches list back to
include the main branch: in the YAML key named branches replace the feature
branch string 'DOC-1590-migration-guidance-for-existing-iceberg-tables-to' with
'main' (preserving the other entries like v/*, shared, site-search), and ensure
the corresponding PR in the redpanda-data/documentation repo is merged first so
single-sourcing remains correct before merging this change.

Copy link
Contributor

@micheleRP micheleRP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! Just a reminder to revert playbook

@kbatuigas kbatuigas merged commit 9eac63d into main Feb 28, 2026
5 checks passed
@kbatuigas kbatuigas deleted the add-new-iceberg-migration-doc-to-cloud branch February 28, 2026 04:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants