Conversation
✅ Deploy Preview for rp-cloud ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
Important Review skippedAuto incremental reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Use the checkbox below for a quick retry:
📝 WalkthroughWalkthroughThis pull request updates Antora playbook configuration to point to a specific feature branch (DOC-1590-migration-guidance-for-existing-iceberg-tables-to) instead of the main branch, adds a new navigation entry in the Iceberg topics section, and introduces a new documentation page describing the migration process for Iceberg Topics, including learning objectives and implementation guidance. Estimated code review effort🎯 2 (Simple) | ⏱️ ~8 minutes Possibly related PRs
Suggested reviewers
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@local-antora-playbook.yml`:
- Line 18: Update the branches list back to include the main branch: in the YAML
key named branches replace the feature branch string
'DOC-1590-migration-guidance-for-existing-iceberg-tables-to' with 'main'
(preserving the other entries like v/*, shared, site-search), and ensure the
corresponding PR in the redpanda-data/documentation repo is merged first so
single-sourcing remains correct before merging this change.
ℹ️ Review info
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Disabled knowledge base sources:
- Jira integration is disabled
You can enable these sources in your CodeRabbit configuration.
📒 Files selected for processing (3)
local-antora-playbook.ymlmodules/ROOT/nav.adocmodules/manage/pages/iceberg/migrate-to-iceberg-topics.adoc
local-antora-playbook.yml
Outdated
| branches: HEAD | ||
| - url: https://github.com/redpanda-data/documentation | ||
| branches: [main, v/*, shared, site-search] | ||
| branches: ['DOC-1590-migration-guidance-for-existing-iceberg-tables-to', v/*, shared, site-search] |
There was a problem hiding this comment.
Revert branch change before merging.
The main branch has been removed from the branches list and replaced with the feature branch DOC-1590-migration-guidance-for-existing-iceberg-tables-to. This is appropriate for local preview builds, but per the cross-repository single sourcing pattern used in this documentation system, the playbook should be reverted to include main before merging this PR.
Ensure the corresponding PR in the redpanda-data/documentation repo is merged first, then restore:
- branches: ['DOC-1590-migration-guidance-for-existing-iceberg-tables-to', v/*, shared, site-search]
+ branches: [main, v/*, shared, site-search]Based on learnings: "The playbook is reverted to main before merging. This cross-repository single sourcing pattern is commonly used."
📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| branches: ['DOC-1590-migration-guidance-for-existing-iceberg-tables-to', v/*, shared, site-search] | |
| branches: [main, v/*, shared, site-search] |
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In `@local-antora-playbook.yml` at line 18, Update the branches list back to
include the main branch: in the YAML key named branches replace the feature
branch string 'DOC-1590-migration-guidance-for-existing-iceberg-tables-to' with
'main' (preserving the other entries like v/*, shared, site-search), and ensure
the corresponding PR in the redpanda-data/documentation repo is merged first so
single-sourcing remains correct before merging this change.
micheleRP
left a comment
There was a problem hiding this comment.
lgtm! Just a reminder to revert playbook
Description
Add redpanda-data/docs#1579 to Cloud.
Resolves https://github.com/redpanda-data/documentation-private/issues/
Review deadline:
Page previews
Checks