SQL: Query topics#574
Conversation
✅ Deploy Preview for rp-cloud ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
4d7b551 to
20ad041
Compare
20ad041 to
ddefdad
Compare
Renames modules/sql/pages/query/ to modules/sql/pages/query-data/ and renames the streaming-topic how-to from query-redpanda-topics.adoc to query-streaming-topics.adoc to match the SQL GA IA. Retitles the page "Query streaming topics" and reframes the description and learning objectives around live streaming data; bridge-query and Iceberg content stays out of this page (DOC-2006 owns the Iceberg-topics how-to). Adds a pointer to the Iceberg topics how-to under the intro and lists it under Next steps. Updates the enable-prereq xref to point to the Enable Redpanda SQL page. Drops the CREATE REDPANDA CATALOG link from Next steps to align with the v1 framing that users do not typically create their own Redpanda catalog. Reframes the Query data index page description for v1 Iceberg scope (live and historical data in Redpanda topics; no external Iceberg lakehouse). Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
# Conflicts: # modules/sql/pages/query-data/redpanda-catalogs.adoc
This reverts commit 522ad59.
75ae890 to
48ead8c
Compare
Feediver1
left a comment
There was a problem hiding this comment.
PR Review: SQL: Query topics (#574)
Files reviewed: 4 .adoc files (109 additions / 94 deletions)
Overall assessment: Solid documentation structure and content. Same integration-branch xref challenges as #571 — six unresolved cross-PR xrefs. One nav-linked stub page with no body. No What's New entry. A couple of em dashes that violate the style guide.
What this PR does
Expands Redpanda SQL query documentation on the rp-sql integration branch:
modules/sql/pages/query-data/index.adoc(new, 3 lines) — section index for "Query Data".modules/sql/pages/query-data/query-streaming-topics.adoc(new, 80 lines) — how-to: map a topic to a SQL table and run analytical queries.modules/sql/pages/query-data/redpanda-catalogs.adoc(1+ / 80−) — heavily reduced from a full reference to a 1-line stub.modules/reference/pages/sql/sql-statements/create-table.adoc(25+ / 14−) — updated reference:schema_subjectnow required, expandedstruct_mapping_policy(with cyclic-type guidance), newconfluent_wire_protocoloption, three full examples.
Jira ticket alignment
Ticket: DOC-1990 — "Document feature query Redpanda topics" (extracted from branch name).
Status: The PR delivers the planned query how-to and refreshes the CREATE TABLE reference. The stubbed redpanda-catalogs.adoc is mentioned in the PR description as "likely to be reworked" — worth confirming what the eventual replacement plan is before the integration branch lands.
Critical issues (must fix)
-
Six broken xrefs to pages that aren't on
rp-sqlor in this branch:File:line xref target Provided by query-streaming-topics.adoc:10sql:query-data/query-iceberg-topics.adocPR #575 (still OPEN) query-streaming-topics.adoc:23sql:get-started/deploy-sql-cluster.adocPR #571 (still OPEN) query-streaming-topics.adoc:24sql:manage/manage-access.adocPR #580 (still OPEN) query-streaming-topics.adoc:25sql:get-started/sql-quickstart.adocPR #571 (still OPEN) query-streaming-topics.adoc:50sql:query-data/query-nested-fields.adocNo known PR provides this — confirm it's planned, or remove the reference query-streaming-topics.adoc:77sql:query-data/query-iceberg-topics.adoc(Next steps)PR #575 (still OPEN) - Fix: Coordinate merge ordering — all sibling PRs need to land on
rp-sqlbeforerp-sqllands onmain, otherwise the build will surface sixtarget of xref not founderrors. Specifically check onquery-nested-fields.adoc— if no PR is in flight for it, the inline reference at line 50 should be removed for now.
- Fix: Coordinate merge ordering — all sibling PRs need to land on
-
redpanda-catalogs.adocis a 1-line stub butnav.adoc:355links to it as "Redpanda Catalogs". Users clicking that nav entry hit an empty page. The PR description acknowledges this is intentional ("likely to be reworked"), but a nav-linked empty page is bad UX.- Fix: Either (a) put a 2–3 sentence placeholder with "Coming soon — see [other page]" pointer, (b) leave the original content until the replacement lands and gut it in a later PR, or (c) remove the line from
nav.adoc:355and re-add when the page has content.
- Fix: Either (a) put a 2–3 sentence placeholder with "Coming soon — see [other page]" pointer, (b) leave the original content until the replacement lands and gut it in a later PR, or (c) remove the line from
-
Missing What's New entry. Same gap as #571: the May 2026 section of
whats-new-cloud.adochas no entry for the Redpanda SQL query workflow. Since this is GA documentation, a coordinated What's New entry should cover both PRs (and the broader SQL GA story across #571 / #575 / #580).- Fix: Add a single "Redpanda SQL: General availability" entry under
== May 2026that covers the get-started + query + auth pages together, rather than fragmenting into per-PR entries.
- Fix: Add a single "Redpanda SQL: General availability" entry under
-
Em dashes in
create-table.adoc(style guide says no em dashes):-
Line 7: "
CREATE TABLEin Redpanda SQL maps Redpanda topics to SQL tables — it does not create standalone tables with user-defined schemas." -
Line 56: "Cyclic types are not supported in
COMPOUNDmode — useJSONfor recursive schemas." -
Fix: Replace both em dashes with either a period + new sentence, a colon, or restructure the clause. Example for line 56: "Cyclic types are not supported in
COMPOUNDmode. UseJSONfor recursive schemas."
-
Suggestions (should consider)
-
Page-title case mismatch on the index.
query-data/index.adoc:1has= Query data(sentence case), butnav.adoc:354labels it as "Query Data" (title case). Per team convention, page titles use title case to match the nav label.- Current:
= Query data - Suggested:
= Query Data
- Current:
-
Stub page comment. The 1-line
redpanda-catalogs.adocuses// stubas the only body marker. If you keep the stub approach, consider a more user-facing placeholder (e.g., a NOTE block or an xref to the related how-to) so the rendered page isn't blank. -
Checks boxes in PR body are all empty. Tick the relevant one ("New feature" or "Content gap") for tracking.
Impact on other files
modules/ROOT/nav.adoc✓ — new pages already in nav at lines 354–357, including the (still-missing)query-iceberg-topics.adocentry at line 357 — consistent with the rp-sql integration plan.modules/get-started/pages/whats-new-cloud.adoc❌ — no SQL GA entry (Critical #3).- Cross-component xrefs verified:
xref:reference:sql/sql-statements/create-table.adoc✓xref:reference:sql/index.adoc✓xref:reference:sql/sql-data-types/row.adoc(in create-table.adoc:56) — exists in rp-sql ✓xref:reference:sql/sql-statements/create-redpanda-catalog.adoc(in create-table.adoc:7) — exists in rp-sql ✓xref:sql:connect-to-sql/index.adoc✓- All other
xref:sql:*xrefs — listed as broken in Critical #1.
- Sibling PR dependencies: #571 (deploy + quickstart), #575 (query-iceberg), #580 (manage-access). Plus the unknown source for
query-nested-fields.adoc.
CodeRabbit findings worth considering
None. CodeRabbit's check passed with no review summary or actionable comments.
What works well
- Clean module layout: index + how-to + reference, all in the right places.
- Comprehensive prerequisites section lists exactly what a reader needs before they can succeed: SQL engine enabled, RBAC permission, psql connection, registered Schema Registry schema.
- Real-world SQL examples beyond toy
SELECT *— aggregation withGROUP BY,ORDER BY,WHEREfilters,LIMIT. - CREATE TABLE reference is thorough: required/optional column in the options table, three full examples (basic, multi-message Protobuf, error handling) covering distinct use cases.
- Frontmatter compliance:
:page-topic-type: how-tofor the how-to,:page-topic-type: referencefor the reference, learning objectives observable and measurable, personas correctly scoped (app_developer,data_engineer— query-side audience, not platform admins). - Sentence case correct on every H2+ heading in the new content.
- Source-block syntax is consistent with the rest of the SQL module (long-form
[source,sql]— matches the convention used inget-started/*.adoc). schema_subjectis now correctly marked Required in the reference table, addressing the schema-required guidance that was unclear before.- Helpful guidance on cyclic types in
struct_mapping_policy— clearly tells users to switch toJSONmode for recursive schemas. confluent_wire_protocoloption fully documented with defaults and when to use each value.- CI is fully green and Netlify preview links cover the two main new pages.
Final-pass review via /docs-team-standards:pr-review.
|
@kbatuigas Ping me again after you get your SME approvals and I can do a more thorough review |
|
|
||
| Map a Redpanda topic to a SQL table to run analytical queries directly against live streaming data without building ETL pipelines. Redpanda SQL reads each record's fields from the topic's registered schema. | ||
|
|
||
| To extend queries past your Redpanda retention window by reading the Iceberg history of Iceberg-enabled topics, see xref:sql:query-data/query-iceberg-topics.adoc[Query Iceberg-enabled Topics]. |
Description
This pull request updates and expands the Redpanda SQL documentation to clarify table mapping, schema requirements, and streaming topic queries. It refines the
CREATE TABLEreference, introduces new how-to guides for querying topics, and streamlines catalog documentation.Documentation improvements for querying and mapping topics:
query-streaming-topics.adoc) that walks users through mapping a Redpanda topic to a SQL table and running analytical queries directly on live data. This guide covers prerequisites, table creation, querying, and links to further resources.query-data/index.adoc) to provide an entry point for users learning to query Redpanda topics with SQL.Enhancements and clarifications in the SQL reference:
CREATE TABLEdocumentation to clarify thatschema_subjectis required and that Redpanda SQL needs a schema to query a topic. Improved the explanation ofstruct_mapping_policy, especially regarding handling of nested and recursive types, and added documentation for theconfluent_wire_protocoloption. [1] [2]Catalog documentation simplification:
Resolves https://github.com/redpanda-data/documentation-private/issues/
Review deadline: 21 May
Page previews
Checks