Add comments explaining where the cidr blocks are coming from#5
Merged
frenchfrywpepper merged 1 commit intomainfrom Jul 9, 2024
Merged
Add comments explaining where the cidr blocks are coming from#5frenchfrywpepper merged 1 commit intomainfrom
frenchfrywpepper merged 1 commit intomainfrom
Conversation
Prior to this commit we had a list of cidr blocks that are used for ingress to redpanda, but there was no explanation about where these 'magic' blocks were coming from or what they represent. Added some comments and included a link to the documentation.
frenchfrywpepper
requested review from
a team,
0x5d,
c4milo,
chapmanc,
ncole and
paulzhang97
paulzhang97
approved these changes
Jul 9, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prior to this commit we had a list of cidr blocks that are used for ingress to redpanda, but there was no explanation about where these 'magic' blocks were coming from or what they represent.
Added some comments and included a link to the documentation.