Support extra endpoint parameters in oauth#2047
Merged
Jeffail merged 2 commits intoredpanda-data:mainfrom Sep 4, 2023
Merged
Conversation
rvangsgaard
force-pushed
the
feature/support-extra-endpoint-parameters-in-oauth2
branch
from
2e15a40 to
794b653
Compare
Collaborator
|
Hey @rvangsgaard, looks good overall but is there a reason to allow |
Signed-off-by: René Vangsgaard <rene.vangsgaard@gmail.com> Co-authored-by: Nikolai Emil Damm <nikolaiemildamm@icloud.com>
rvangsgaard
force-pushed
the
feature/support-extra-endpoint-parameters-in-oauth2
branch
from
794b653 to
1fe3f94
Compare
…ra-endpoint-parameters-in-oauth2
Contributor
Author
There is no reason to allow any values. This is now fixed. |
Jeffail
approved these changes
Sep 4, 2023
Collaborator
Jeffail
left a comment
Jeffail
left a comment
There was a problem hiding this comment.
LGTM, thanks @rvangsgaard!
Jeffail
approved these changes
Sep 4, 2023
Collaborator
Jeffail
left a comment
Jeffail
left a comment
There was a problem hiding this comment.
LGTM, thanks @rvangsgaard
rvangsgaard
deleted the
feature/support-extra-endpoint-parameters-in-oauth2
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.