feat(input_kinesis): Decouple DynamoDB session from kinesis to allow cross account #3165
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
mihaitodor
force-pushed
the
with_kinenis_op_role_ddb
branch
from
80fdedc to
59359a9
Compare
Contributor
|
Hey @jreyeshdez, thank you for the contribution! I took a slightly different approach to ensure we preserve backwards compatibility for existing configs. My changes required a few changes in the Benthos framework (see here) which will be merged later this week and then we can also merge this PR. If you have a bit of time, could you please check if this updated code works correctly for you (you'll have to fetch the Benthos updates as well)? |
mihaitodor
force-pushed
the
with_kinenis_op_role_ddb
branch
from
59359a9 to
fa9834c
Compare
Contributor
Author
|
@mihaitodor it seems it works as before, so I think it is safe to go ahead and merge. |
Signed-off-by: Mihai Todor <todormihai@gmail.com>
mihaitodor
force-pushed
the
with_kinenis_op_role_ddb
branch
from
fa9834c to
5139af7
Compare
mihaitodor
approved these changes
Apr 5, 2025
Contributor
mihaitodor
left a comment
mihaitodor
left a comment
There was a problem hiding this comment.
LGTM, thank you for the contribution @jreyeshdez! The changes will be available in the next release.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DynamoDB table could be in different AWS account than kinesis input stream, this lets one to use different AWS credentials if needed for dynamodb.
Tackles #3159