Bugfix: amqp_0_9 output: only enforce dots in routing keys for topic exchanges #3275
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
brknstrngz
commented
Mar 22, 2025
brknstrngz
commented
- we currently replace all slashes in routing keys and message types with dots; this is however not mandated for any other exchange type than 'topic'. This change adds a check that skips the replacement for non-topic exchanges, such as 'direct'
- add support for the 'headers' exchange type
brknstrngz
changed the title
- we currently replace all slashes in routing keys and message types with dots; this is however not mandated for any other exchange type than 'topic'. This change adds a check that skips the replacement for non-topic exchanges, such as 'direct'
Signed-off-by: Mihai Todor <todormihai@gmail.com>
mihaitodor
force-pushed
the
brknstrngz/bugfix/dots_in_routing_keys_for_topic_exchanges
branch
from
c378ccb to
db854e4
Compare
mihaitodor
approved these changes
Mar 31, 2025
Contributor
mihaitodor
left a comment
mihaitodor
left a comment
There was a problem hiding this comment.
Thank you for the contribution @brknstrngz! LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.