Skip to content

dynamodb_cdc: add benchmark tooling#4102

Merged
squiidz merged 2 commits intomainfrom
dynamodb_cdc_bench
Mar 16, 2026
Merged

dynamodb_cdc: add benchmark tooling#4102
squiidz merged 2 commits intomainfrom
dynamodb_cdc_bench

Conversation

@squiidz
Copy link
Copy Markdown
Contributor

@squiidz squiidz commented Mar 12, 2026

Add a self-contained benchmark under internal/impl/aws/dynamodb/bench/ that seeds 450k items into DynamoDB Local and measures CDC throughput via the aws_dynamodb_cdc input.

Run with: task run

Add a self-contained benchmark under internal/impl/aws/dynamodb/bench/
that seeds 450k items into DynamoDB Local and measures CDC throughput
via the aws_dynamodb_cdc input.

Run with: task run
@claude
Copy link
Copy Markdown

claude Bot commented Mar 12, 2026

Commits
LGTM

Review
Single-commit PR adds a self-contained DynamoDB CDC benchmark tool under internal/impl/aws/dynamodb/bench/. Includes a data seeder (main.go), Taskfile, benchmark config, and README. This is a standalone benchmark utility, not a component, so component-specific patterns (registration, ConfigSpec, field constants, etc.) don't apply. Error handling, license header, and context usage are all correct.

LGTM

@squiidz squiidz force-pushed the dynamodb_cdc_bench branch from def0bf5 to 6e1bd5f Compare March 12, 2026 19:05
@claude
Copy link
Copy Markdown

claude Bot commented Mar 12, 2026

Commits
LGTM

Review
Adds standalone benchmark tooling for DynamoDB CDC: a data generation CLI (main.go), Taskfile, benchmark config, and README. License headers, error handling, and context usage are all correct.

LGTM

@claude
Copy link
Copy Markdown

claude Bot commented Mar 12, 2026

Commits

  1. linter fix (bd9b167): Does not match any valid commit message format. Must use a system prefix (e.g., dynamodb_cdc: fix linter issue) or chore: fix linter issue per commit policy. Additionally, this appears to be a fixup of the first commit and should be squashed before merge.

Review
The PR adds a self-contained benchmark tool for DynamoDB CDC under internal/impl/aws/dynamodb/bench/. Code is clean: proper RCL license header, correct error handling, safe concurrency patterns with atomics and channels, and dummy credentials appropriate for DynamoDB Local.

LGTM

@squiidz squiidz merged commit e98236a into main Mar 16, 2026
7 checks passed
@squiidz squiidz deleted the dynamodb_cdc_bench branch March 16, 2026 18:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants